Add a RunInSafeDuplicatedContext annotation #34636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
cescoffier
force-pushed
the
run-in-safe-duplicated-context
branch
from
9974e8d to
921ae76
Compare
|
🙈 The PR is closed and the preview is expired. |
mkouba
reviewed
Jul 10, 2023
...me/src/main/java/io/quarkus/vertx/core/runtime/context/SafeDuplicatedContextInterceptor.java
Outdated
Show resolved
Hide resolved
mkouba
reviewed
Jul 10, 2023
mkouba
reviewed
Jul 10, 2023
.../runtime/src/main/java/io/quarkus/vertx/core/runtime/context/RunInSafeDuplicatedContext.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
cescoffier
force-pushed
the
run-in-safe-duplicated-context
branch
from
921ae76 to
37b9057
Compare
|
@mkouba I've handled your comment (including using your name suggestion) |
mkouba
reviewed
Jul 13, 2023
...ions/vertx/runtime/src/main/java/io/quarkus/vertx/core/runtime/context/SafeVertxContext.java
Outdated
Show resolved
Hide resolved
...ions/vertx/runtime/src/main/java/io/quarkus/vertx/core/runtime/context/SafeVertxContext.java
Outdated
Show resolved
Hide resolved
...ions/vertx/runtime/src/main/java/io/quarkus/vertx/core/runtime/context/SafeVertxContext.java
Outdated
Show resolved
Hide resolved
...runtime/src/main/java/io/quarkus/vertx/core/runtime/context/SafeVertxContextInterceptor.java
Outdated
Show resolved
Hide resolved
...runtime/src/main/java/io/quarkus/vertx/core/runtime/context/SafeVertxContextInterceptor.java
Show resolved
Hide resolved
Allows a method to mark the calling duplicated context as safe.
cescoffier
force-pushed
the
run-in-safe-duplicated-context
branch
from
37b9057 to
877dede
Compare
Failing Jobs - Building 877dede
Failures⚙️ JVM Tests - JDK 17 #- Failing: extensions/reactive-pg-client/deployment
! Skipped: extensions/hibernate-reactive/deployment extensions/panache/hibernate-reactive-panache-common/deployment extensions/panache/hibernate-reactive-panache-kotlin/deployment and 14 more📦 extensions/reactive-pg-client/deployment✖ |
|
@mkouba can you recheck? |
mkouba
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a method to mark the calling duplicated context as safe.